RFR: 8339570: Add Tidy build support for JDK tests [v7]

Nizar Benalla nbenalla at openjdk.org
Mon Oct 14 11:04:44 UTC 2024


> Can I get a review for this patch that adds the necessary changes for local support of the `tidy` library.
> 
> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` on Linux and MacOs systems.
> 
> This dependency is primarily going to be used to test the generated documentation.
> 
> This patch is meant to be integrated before #21272.
> 
> Note: we need to be a very specific revision of `tidy` and cannot use any of the available artifacts, as older versions do not recognize some HTML 5 elements. 
> 
> TIA

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into tidy-local-build-support
 - - provide tidy to linux-aarch64.
   - add condition to module name for tidy
   - add new condition when passing the path to tidy
 - Add small comment to `createTidyBundle`
 - revert fd95431e and remove `tidy` as a dependency for linux-aarch64. Not needed currently
 - define the module as tidy-html + target_platform, as the linux binary is not multi arch
 - update after getting review comments
 - Merge remote-tracking branch 'upstream/master' into tidy-local-build-support
 - (C)
 - 8339570: Add Tidy build support for JDK tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21341/files
  - new: https://git.openjdk.org/jdk/pull/21341/files/e0bb1035..0fc3a1c7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21341&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21341&range=05-06

  Stats: 18929 lines in 334 files changed: 15929 ins; 1284 del; 1716 mod
  Patch: https://git.openjdk.org/jdk/pull/21341.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21341/head:pull/21341

PR: https://git.openjdk.org/jdk/pull/21341


More information about the build-dev mailing list