RFR: 8339570: Add Tidy build support for JDK tests [v7]

[Magnus Ihse Bursie]

On Mon, 14 Oct 2024 11:04:44 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I get a review for this patch that adds the necessary changes for local support of the `tidy` library.
>> 
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` on Linux and MacOs systems.
>> 
>> This dependency is primarily going to be used to test the generated documentation.
>> 
>> This patch is meant to be integrated before #21272.
>> 
>> Note: we need to be a very specific revision of `tidy` and cannot use any of the available artifacts, as older versions do not recognize some HTML 5 elements. 
>> 
>> TIA
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into tidy-local-build-support
>  - - provide tidy to linux-aarch64.
>    - add condition to module name for tidy
>    - add new condition when passing the path to tidy
>  - Add small comment to `createTidyBundle`
>  - revert fd95431e and remove `tidy` as a dependency for linux-aarch64. Not needed currently
>  - define the module as tidy-html + target_platform, as the linux binary is not multi arch
>  - update after getting review comments
>  - Merge remote-tracking branch 'upstream/master' into tidy-local-build-support
>  - (C)
>  - 8339570: Add Tidy build support for JDK tests

The TIDY_HOME stuff is just redundant. You are setting TIDY as a configure argument, you do not need TIDY_HOME. That just adds complexity for code that will never be run. Remove the environment from the jib definition, and the check in RunTests.gmk.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21341#issuecomment-2411079810