RFR: 8339570: Add Tidy build support for JDK tests [v11]

[Mikael Vidstedt]

On Wed, 16 Oct 2024 13:02:52 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I get a review for this patch that adds the necessary changes for local support of the `tidy` library.
>> 
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` on Linux and MacOs systems.
>> 
>> This dependency is primarily going to be used to test the generated documentation.
>> 
>> This patch is meant to be integrated before #21272.
>> 
>> Note: we need to be a very specific revision of `tidy` and cannot use any of the available artifacts, as older versions do not recognize some HTML 5 elements. 
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert changes to RunTestsPrebuiltSpec.gmk

make/devkit/createTidyBundle.sh line 79:

> 77: 
> 78: cd "$SCRIPT_DIR"
> 79: rm -rf $SRC_DIR

Double quotes for good luck

make/devkit/createTidyBundle.sh line 84:

> 82: PACKAGED_FILE="tidy-html5.tar.gz"
> 83: 
> 84: tar -czvf "$PACKAGED_FILE" -C $INSTALL_PREFIX.. tidy

Double quotes around `$INSTALL_PREFIX` for good luck

make/devkit/createTidyBundle.sh line 86:

> 84: tar -czvf "$PACKAGED_FILE" -C $INSTALL_PREFIX.. tidy
> 85: 
> 86: echo "Created $INSTALL_PREFIX/../$PACKAGED_FILE"

Nit: `$INSTALL_PREFIX` already incudes a slash. I think it would be clearer if it didn't, other variables like it tend not to.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1803616825
PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1803618632
PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1803616638