RFR: 8339570: Add Tidy build support for JDK tests [v11]

Nizar Benalla nbenalla at openjdk.org
Fri Oct 18 08:43:42 UTC 2024


On Wed, 16 Oct 2024 18:36:14 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert changes to RunTestsPrebuiltSpec.gmk
>
> make/devkit/createTidyBundle.sh line 79:
> 
>> 77: 
>> 78: cd "$SCRIPT_DIR"
>> 79: rm -rf $SRC_DIR
> 
> Double quotes for good luck

Fixed in [47a67f2](https://github.com/openjdk/jdk/pull/21341/commits/47a67f2eaba3a4fe1afa1e09cdf03d334b55c2d2), thanks!

> make/devkit/createTidyBundle.sh line 86:
> 
>> 84: tar -czvf "$PACKAGED_FILE" -C $INSTALL_PREFIX.. tidy
>> 85: 
>> 86: echo "Created $INSTALL_PREFIX/../$PACKAGED_FILE"
> 
> Nit: `$INSTALL_PREFIX` already incudes a slash. I think it would be clearer if it didn't, other variables like it tend not to.

Fixed in [47a67f2](https://github.com/openjdk/jdk/pull/21341/commits/47a67f2eaba3a4fe1afa1e09cdf03d334b55c2d2), thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1806115401
PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1806112195


More information about the build-dev mailing list