RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY

[Erik Joelsson]

On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> In [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), the keyword is 'TEST_THREAD_FACTORY'.
> 
> So the below test command will print error:
> 
> make test TEST=test/jdk/java/math/BigInteger/TestValueExact.java CONF=linux-x86_64-server-release JTREG="JTREG_TEST_THREAD_FACTORY=Virtual"
> 
> 
> Building target 'test' in configuration 'linux-x86_64-server-release'
> JTREG_TEST_THREAD_FACTORY=Virtual is not a valid keyword for JTREG.
> Valid keywords: JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT REPEAT_COUNT MAX_OUTPUT REPORT OPTIONS JAVA_OPTIONS VM_OPTIONS KEYWORDS EXTRA_PROBLEM_LISTS LAUNCHER_OPTIONS.
> RunTests.gmk:206: *** Cannot continue. Stop.
> 
> 
> So I think we should fix the document bug in `doc/testing.md` to avoid take the same mistake. Trivial fix, no risk.

test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetObjectMonitorUsage/objmonusage001.java line 66:

> 64:         // Virtual threads are not supported by GetObjectMonitorUsage.
> 65:         // Correct the expected values if the test is executed with
> 66:         // TEST_THREAD_FACTORY=Virtual.

Perhaps these references should use the full `JTREG=TEST_THREAD_FACTORY=Virtual` to make it clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21594#discussion_r1808734633