RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

SendaoYan syan at openjdk.org
Mon Oct 21 13:12:56 UTC 2024


On Mon, 21 Oct 2024 12:48:55 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JTREG="TEST_THREAD_FACTORY=Virtual"
>>  - Use JTREG="JTREG_TEST_THREAD_FACTORY=Virtual" to make comment more cleaner
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetObjectMonitorUsage/objmonusage001.java line 66:
> 
>> 64:         // Virtual threads are not supported by GetObjectMonitorUsage.
>> 65:         // Correct the expected values if the test is executed with
>> 66:         // TEST_THREAD_FACTORY=Virtual.
> 
> Perhaps these references should use the full `JTREG=TEST_THREAD_FACTORY=Virtual` to make it clearer.

Thanks for the review, use `JTREG="TEST_THREAD_FACTORY=Virtual"` to make comment more clearer

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21594#discussion_r1808787158


More information about the build-dev mailing list