RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

[Magnus Ihse Bursie]

On Fri, 25 Oct 2024 04:47:19 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> make/autoconf/flags-cflags.m4 line 589:
>> 
>>> 587:   # CXXFLAGS C++ language level for all of JDK, including Hotspot.
>>> 588:   if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" = xclang; then
>>> 589:     LANGSTD_CXXFLAGS="-std=c++14"
>> 
>> Is this really an intention on your part, to bump the C++ level inside a PR to remove unused code? 😕 Or is it a merge error from a different PR?
>
> It's a checkout error from the original gigantic Pull Request, sorry. I don't plan to raise the JDK to C++17 in this one. But I'm not sure what to do with this now, since maybe_unused is C++17. I don't think anyone is going to appreciate [[gnu::unused]] inside Windows code

Then you'll have to create a macro for disabling the unused warnings (however, I'm not sure how well that would be received). Or fix the bug if it is actually unused. Or wait until we go to 17.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21655#discussion_r1816412298