RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

[Julian Waters]

On Fri, 25 Oct 2024 10:11:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> It's a checkout error from the original gigantic Pull Request, sorry. I don't plan to raise the JDK to C++17 in this one. But I'm not sure what to do with this now, since maybe_unused is C++17. I don't think anyone is going to appreciate [[gnu::unused]] inside Windows code
>
> Then you'll have to create a macro for disabling the unused warnings (however, I'm not sure how well that would be received). Or fix the bug if it is actually unused. Or wait until we go to 17.

I don't think it's a bug since the error is an unused pointer typedef, and it seems customary to provide the pointer typedef alongside the actual struct in awt code, even if not needed. I could just disable the warning for the file in the port, but that way no more potential bugfixes in that file would be possible

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21655#discussion_r1816554048