RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v8]

Magnus Ihse Bursie ihse at openjdk.org
Tue Oct 29 15:29:20 UTC 2024


On Tue, 29 Oct 2024 09:16:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove thread_ptr_offset remnants
>
> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp line 87:
> 
>> 85:     volatile Thread* wrapperthread = thread;
>> 86: 
>> 87:     if (os::win32::get_thread_ptr_offset() == 0) {
> 
> I think `os::win32::get_thread_ptr_offset` is not needed now and  ./os_cpu/windows_x86/assembler_windows_x86.cpp looks like it can be deleted.

I just redisovered this by myself from your previous comment. :) However, there were some more `thread_ptr_offset` I could remove.

`assembler_windows_x86.cpp` is heavily cut down, but can't be fully removed since it contains the Windows implementation of `MacroAssembler::int3()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1821037756


More information about the build-dev mailing list