RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v9]

Magnus Ihse Bursie ihse at openjdk.org
Tue Oct 29 15:33:51 UTC 2024


On Tue, 29 Oct 2024 09:37:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clean up old Windows workarounds in adlc
>
> src/hotspot/share/utilities/globalDefinitions_visCPP.hpp line 55:
> 
>> 53: #error unsupported platform
>> 54: #endif
>> 55: 
> 
> Does Windows Aarch64 define _LP64?

Yes. As Julian says, it's something we set up in our builds:

  if test "x$FLAGS_CPU_BITS" = x64; then
    $1_DEFINES_CPU_JDK="${$1_DEFINES_CPU_JDK} -D_LP64=1"
    $1_DEFINES_CPU_JVM="${$1_DEFINES_CPU_JVM} -D_LP64=1"
  fi

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1821060520


More information about the build-dev mailing list