RFR: 8339336: Fix build system whitespace to adhere to coding conventions [v2]

[Magnus Ihse Bursie]

On Fri, 30 Aug 2024 19:29:56 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix bad change in BuildMicrobenchmarks
>
> make/MainSupport.gmk line 202:
> 
>> 200:   $(foreach i, 2 3 4 5 6 7 8, $(if $(strip $($i)),$(strip $1)_$(strip $($i)))$(NEWLINE))
>> 201:   $(if $(9), $(error Internal makefile error: Too many arguments to \
>> 202:       DeclareRecipesForPhase, please update MakeHelper.gmk))
> 
> I know this is a whitespace cleanup, so this should likely be addressed in a separate issue, but this error message is referencing `MakeHelper.gmk` while being in the file `MainSupport.gmk`.  Also, shouldn't this be able to use the `NamedParamsMacroTemplate` instead of using this old technique for named arguments?

Yes, I agree on all accounts. We have some other places left as well where `NamedParamsMacroTemplate` is not used even though it should be. Feel free to open a bug.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20798#discussion_r1740197840