RFR: 8339336: Fix build system whitespace to adhere to coding conventions [v2]

[Magnus Ihse Bursie]

On Sun, 1 Sep 2024 21:34:48 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/MainSupport.gmk line 202:
>> 
>>> 200:   $(foreach i, 2 3 4 5 6 7 8, $(if $(strip $($i)),$(strip $1)_$(strip $($i)))$(NEWLINE))
>>> 201:   $(if $(9), $(error Internal makefile error: Too many arguments to \
>>> 202:       DeclareRecipesForPhase, please update MakeHelper.gmk))
>> 
>> I know this is a whitespace cleanup, so this should likely be addressed in a separate issue, but this error message is referencing `MakeHelper.gmk` while being in the file `MainSupport.gmk`.  Also, shouldn't this be able to use the `NamedParamsMacroTemplate` instead of using this old technique for named arguments?
>
> Yes, I agree on all accounts. We have some other places left as well where `NamedParamsMacroTemplate` is not used even though it should be. Feel free to open a bug.

I opened https://bugs.openjdk.org/browse/JDK-8339370

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20798#discussion_r1740570425