RFR: 8339336: Fix build system whitespace to adhere to coding conventions [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Sep 2 09:04:20 UTC 2024
On Sun, 1 Sep 2024 21:35:02 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> The build system code has unfortunately diverted in some places from the conventions as described in https://openjdk.org/groups/build/doc/code-conventions.html.
>>
>> Instead of trying to fix these when touching code nearby, I'd like to make an effort to fix all issues at once and separately. Incremental fixes has their benefit, but they can also muddy the actual fix and are not always appreciated.
>>
>> The updates in this patch have all been discovered using automated tools, but each and every change has been manually scrutinized. Those that the automatic tools pointed out that, but that were not obviously or clear-cut safe (e.g. adding spaces after comma, in `subst` or similar situations) were reverted before I pushed. I chose to err on the "First, do no harm" side, so there might be places that could have been corrected, but were not.
>>
>> I have made a single type of change per commit in this branch. It might be easier to review this by looking at one commit at a time.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix bad change in BuildMicrobenchmarks
Running compare builds sounds like a good safety measure.
I've done that now, and it looks clean on all platforms. (With one exception: we include the vardeps files for jar files in jdk/demos -- historical reasons, I assume -- and they look slightly different; but they should not really have been included in the comparison anyway so it does not matter.)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20798#issuecomment-2324197646
More information about the build-dev
mailing list