RFR: 8339371: jlink.log warning when building after JDK-8338404
Erik Joelsson
erikj at openjdk.org
Tue Sep 3 16:13:23 UTC 2024
On Mon, 2 Sep 2024 12:20:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> After JDK-8338404, the build produces warnings like:
>
> /bin/tee: /localhome/git/jdk-CDR/build/linux-x64/support/interim-image/jlink.log: No such file or directory
>
> Fix this by using a proper SetupExecute instead.
Marked as reviewed by erikj (Reviewer).
make/InterimImage.gmk line 51:
> 49: OUTPUT_DIR := $(INTERIM_IMAGE_DIR), \
> 50: SUPPORT_DIR := $(INTERIM_JLINK_SUPPORT_DIR), \
> 51: COMMAND := $(RM) -r $(INTERIM_IMAGE_DIR) && $(JLINK_TOOL) --output $(INTERIM_IMAGE_DIR) \
In Images.gmk, we use the `PRE_COMMAND` option for running `rm`. Maybe you want to use the same pattern here?
-------------
PR Review: https://git.openjdk.org/jdk/pull/20814#pullrequestreview-2277895103
PR Review Comment: https://git.openjdk.org/jdk/pull/20814#discussion_r1742330874
More information about the build-dev
mailing list