RFR: 8339371: jlink.log warning when building after JDK-8338404 [v2]

[Magnus Ihse Bursie]

On Tue, 3 Sep 2024 16:10:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use PRE_COMMAND instead
>
> make/InterimImage.gmk line 51:
> 
>> 49:     OUTPUT_DIR := $(INTERIM_IMAGE_DIR), \
>> 50:     SUPPORT_DIR := $(INTERIM_JLINK_SUPPORT_DIR), \
>> 51:     COMMAND := $(RM) -r $(INTERIM_IMAGE_DIR) && $(JLINK_TOOL) --output $(INTERIM_IMAGE_DIR) \
> 
> In Images.gmk, we use the `PRE_COMMAND` option for running `rm`. Maybe you want to use the same pattern here?

That's a good suggestion. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20814#discussion_r1742441334