RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files [v2]
Sean Coffey
coffeys at openjdk.org
Wed Sep 11 15:16:08 UTC 2024
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> This is a follow on fix to [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone." Same fix, i.e, replacing `startsWith()` with `regionMatches()` was applied.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>
> tz files aligned with the default TzdbZoneRulesProvider list
LGTM
`sun/util/calendar/zi/TestZoneInfo310.java` exercises the tzdb compiler. I wonder if it's worth adding some dummy rules which test the new leniency added to the compiler ? (perhaps even just to the jdk11_backward file included in the test dir)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20940#issuecomment-2343959123
More information about the build-dev
mailing list