RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files [v2]

[Naoto Sato]

On Wed, 11 Sep 2024 15:13:25 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tz files aligned with the default TzdbZoneRulesProvider list
>
> LGTM
> 
> `sun/util/calendar/zi/TestZoneInfo310.java` exercises the tzdb compiler. I wonder if it's worth adding some dummy rules which test the new leniency added to the compiler ? (perhaps even just to the jdk11_backward file included in the test dir)

Thanks, @coffeys 

> `sun/util/calendar/zi/TestZoneInfo310.java` exercises the tzdb compiler. I wonder if it's worth adding some dummy rules which test the new leniency added to the compiler ? (perhaps even just to the jdk11_backward file included in the test dir)

IIUC the purpose of that test is to check the integrity of `tzdb.dat` which is created at the JDK build time, with the pre-310 era javazic. So adding extra tz files at the test time would break (because `tzdb.dat` do not include that lenient test tz file). Testing of JDK build tool is hard IMO.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20940#issuecomment-2344111564