RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v4]
Robbin Ehn
rehn at openjdk.org
Tue Sep 24 06:00:37 UTC 2024
On Tue, 24 Sep 2024 03:50:29 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refine comment
>
> src/hotspot/cpu/riscv/riscv.ad line 10078:
>
>> 10076: match(CallLeafVector);
>> 10077:
>> 10078: effect(USE meth);
>
> It's possible for the runtime call to clobber rFlagsReg `cr` (aka `t1`). So safer to add `KILL cr` to the effect.
Good find, it will definitely be clobbered.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1772674338
More information about the build-dev
mailing list