RFR: 8315844: $LSB_RELEASE is not defined before use

Magnus Ihse Bursie ihse at openjdk.org
Thu Apr 3 18:42:54 UTC 2025


On Thu, 3 Apr 2025 14:39:19 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> When running configure on WSL, the following error message is printed, instead of proper Linux environment info:
>> 
>> 
>>     /build/.configure-support/generated-configure.sh: line 13102: -d: command not found 
>> 
>> 
>> This is due to us calling `$LSB_RELEASE -d`, but LSB_RELEASE is not yet defined at that point in time. Fix this by moving the LSB_RELEASE check forward.
>
> make/autoconf/basic_tools.m4 line 109:
> 
>> 107:   UTIL_LOOKUP_PROGS(WHOAMI, whoami)
>> 108: 
>> 109:   # Tools only needed on some platforms
> 
> Comment still relevant? Or is it needed on all platforms?

No, so I removed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24409#discussion_r2027552724


More information about the build-dev mailing list