RFR: 8315844: $LSB_RELEASE is not defined before use

Magnus Ihse Bursie ihse at openjdk.org
Fri Apr 4 13:22:15 UTC 2025


On Thu, 3 Apr 2025 18:40:05 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/autoconf/basic_tools.m4 line 109:
>> 
>>> 107:   UTIL_LOOKUP_PROGS(WHOAMI, whoami)
>>> 108: 
>>> 109:   # Tools only needed on some platforms
>> 
>> Comment still relevant? Or is it needed on all platforms?
>
> No, so I removed it.

Ah, sorry, now I realize what you meant (perhaps). I moved the line to a block of lookups that is already preceded by the very same comment. It is still true that lsb_release is only needed on some platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24409#discussion_r2028800957


More information about the build-dev mailing list