RFR: 8282493: Add --with-jcov-modules convenience option
Magnus Ihse Bursie
ihse at openjdk.org
Wed Apr 9 10:27:40 UTC 2025
On Tue, 8 Apr 2025 19:38:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Allow the user to set "--with-jcov-modules=java.desktop", instead of "--with-jcov-filters=--include-modules java.desktop", since this is one of the common use cases for the filtering.
>
> make/Coverage.gmk line 42:
>
>> 40: JCOV_TEMP := $(JCOV_SUPPORT_DIR)/temp
>> 41:
>> 42: ifneq ($(JCOV_MODULES), )
>
> Is this redundant conditional done on purpose?
You mean as in a foreach on an empty variable will yield nothing? Yes, I thought that made to code clearer, but if you think otherwise I can remove it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24481#discussion_r2035070873
More information about the build-dev
mailing list