RFR: 8282493: Add --with-jcov-modules convenience option

Erik Joelsson erikj at openjdk.org
Wed Apr 9 14:09:42 UTC 2025


On Wed, 9 Apr 2025 10:24:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/Coverage.gmk line 42:
>> 
>>> 40: JCOV_TEMP := $(JCOV_SUPPORT_DIR)/temp
>>> 41: 
>>> 42: ifneq ($(JCOV_MODULES), )
>> 
>> Is this redundant conditional done on purpose?
>
> You mean as in a foreach on an empty variable will yield nothing? Yes, I thought that made to code clearer, but if you think otherwise I can remove it.

No, it's fine, I just wanted to know if it was intentional for code clarity.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24481#discussion_r2035457864


More information about the build-dev mailing list