RFR: 8349140: Size optimization (opt-size) build fails after recent PCH changes

[Julian Waters]

On Tue, 4 Feb 2025 16:01:39 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> make/hotspot/lib/JvmOverrideFiles.gmk line 154:
>> 
>>> 152: else ifeq ($(call isTargetOs, windows), true)
>>> 153:   JVM_PRECOMPILED_HEADER_EXCLUDE := \
>>> 154:       bytecodeInterpreter.cpp \
>> 
>> Does bytecodeInterpreter.cpp and friend no longer need to be excluded from precompiled headers? Windows/Zero might not exist yet, but I don't think we'd want to preclude that
>
> I cannot find a bytecodeInterpreterWithChecks.cpp  , where is this located ?  Regarding bytecodeInterpreter.cpp I see no differences in opt setting, so far I don't know why this one should be excluded .

On closer inspection bytecodeInterpreterWithChecks.cpp might be a remnant of the old Interpreter that no longer exists. Alright, this should be ok then

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23442#discussion_r1941496260