RFR: 8349140: Size optimization (opt-size) build fails after recent PCH changes
Martin Doerr
mdoerr at openjdk.org
Tue Feb 4 16:32:11 UTC 2025
On Tue, 4 Feb 2025 16:21:05 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> I cannot find a bytecodeInterpreterWithChecks.cpp , where is this located ? Regarding bytecodeInterpreter.cpp I see no differences in opt setting, so far I don't know why this one should be excluded .
>
> On closer inspection bytecodeInterpreterWithChecks.cpp might be a remnant of the old Interpreter that no longer exists. Alright, this should be ok then
I think bytecodeInterpreterWithChecks was removed a long time ago. It is still referenced in 8u-dev: https://github.com/openjdk/jdk8u-dev/blob/master/hotspot/src/share/vm/interpreter/bytecodeInterpreterWithChecks.xml
I guess that both interpreter excludes could be removed from `JVM_PRECOMPILED_HEADER_EXCLUDE`. @coleenp may know more.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23442#discussion_r1941511445
More information about the build-dev
mailing list