RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v2]

Aleksey Shipilev shade at openjdk.org
Wed Feb 26 18:03:01 UTC 2025


On Wed, 26 Feb 2025 17:58:08 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>> 
>>  - Rename build-linux-x64-static job to build-linux-x64-static-jdk. Remove build-linux-static.yml.
>>  - Merge branch 'master' into JDK-8349399
>>  - Set matrix.
>>  - Remove debug build for now.
>>  - Set debug-levels to "release".
>>  - Set debug-levels to "debug".
>>  - Add build-linux-static.yml.
>>  - Add build-linux-static.yml.
>>  - Add build-linux-x64-static build job in GHA.
>
> .github/workflows/main.yml line 171:
> 
>> 169:     if: needs.prepare.outputs.linux-x64 == 'true'
>> 170: 
>> 171:   build-linux-x64-static-jdk:
> 
> Move this closer to `build-linux-x64-static-libs`? These are somewhat related, at least in their need for `debug-levels: release`. Probably copy a comment about debug-level there.

Also maybe just `build-linux-x64-static`? `-jdk` feels a bit redundant. I see you had it before, would you still prefer `...-static-jdk`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23471#discussion_r1972094716


More information about the build-dev mailing list