RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v2]
Jiangli Zhou
jiangli at openjdk.org
Wed Feb 26 18:13:58 UTC 2025
On Wed, 26 Feb 2025 17:59:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> .github/workflows/main.yml line 171:
>>
>>> 169: if: needs.prepare.outputs.linux-x64 == 'true'
>>> 170:
>>> 171: build-linux-x64-static-jdk:
>>
>> Move this closer to `build-linux-x64-static-libs`? These are somewhat related, at least in their need for `debug-levels: release`. Probably copy a comment about debug-level there.
>
> Also maybe just `build-linux-x64-static`? `-jdk` feels a bit redundant. I see you had it before, would you still prefer `...-static-jdk`?
Thanks for the quick look, @shipilev! Also, thanks for separating the static-libs-bundle with https://github.com/openjdk/jdk/pull/23715. I haven't responded to your earlier comment as I wanted to wait for the GHA testing results.
I renamed to `...-static-jdk` to be more consistent with the new `...-static-libs` job. `build-linux-x64-static` still sounds fine to me, I'll rename it back.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23471#discussion_r1972109329
More information about the build-dev
mailing list