RFR: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once [v3]

Daniel Hu duke at openjdk.org
Wed Jul 9 21:17:17 UTC 2025


> These changes should prevent entire binary files from being loaded into memory for build/AbsPathsInImage.java test. I chose a default buffer size of 8KB since BufferedInputStream uses that, but open to alternative solutions. GHA passes and test passes on linux x64.

Daniel Hu has updated the pull request incrementally with one additional commit since the last revision:

  redid byte matching which should fix cross chunk strings

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26030/files
  - new: https://git.openjdk.org/jdk/pull/26030/files/eb63b162..ef391ba9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26030&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26030&range=01-02

  Stats: 56 lines in 1 file changed: 5 ins; 25 del; 26 mod
  Patch: https://git.openjdk.org/jdk/pull/26030.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26030/head:pull/26030

PR: https://git.openjdk.org/jdk/pull/26030


More information about the build-dev mailing list