RFR: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once [v4]

Daniel Hu duke at openjdk.org
Wed Jul 9 22:28:56 UTC 2025


> These changes should prevent entire binary files from being loaded into memory for build/AbsPathsInImage.java test. I chose a default buffer size of 8KB since BufferedInputStream uses that, but open to alternative solutions. GHA passes and test passes on linux x64.

Daniel Hu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'openjdk:master' into 8341735
 - redid byte matching which should fix cross chunk strings
 - style improvements
 - remove 8341024
 - remove trailing whitespace
 - fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26030/files
  - new: https://git.openjdk.org/jdk/pull/26030/files/ef391ba9..c3d7a77b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26030&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26030&range=02-03

  Stats: 15631 lines in 580 files changed: 9131 ins; 2505 del; 3995 mod
  Patch: https://git.openjdk.org/jdk/pull/26030.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26030/head:pull/26030

PR: https://git.openjdk.org/jdk/pull/26030


More information about the build-dev mailing list