RFR: 8350801: Add a code signing hook to the JDK build system

Frederic Thevenet fthevenet at openjdk.org
Tue Mar 25 11:32:33 UTC 2025


On Mon, 24 Mar 2025 20:49:23 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Actually, I think there is a UTIL_FIXUP_EXECUTABLE, which takes care of adding FIXPATH and fixes any issues with `.exe` on Windows. That is the one you should use.

Thanks @magicus. I have reverted my changes in favour of using `UTIL_FIXUP_EXECUTABLE` instead.

> Also, the addition of the `executable` test was good! Please re-instantiate it.
> 
> I'm not sure if @tstuefe meant that it should be removed? If so, why? To be able to pass in a shell script that does not have the executable bit set? That's kind of weird. How do we even know it is a bash script then? It might just as well be a ksh or csh script, so just assuming bash would be strange.

I removed the check because I noticed that `UTIL_FIXUP_EXECUTABLE` already performs such a check and so it was redundant.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23807#issuecomment-2750792636
PR Comment: https://git.openjdk.org/jdk/pull/23807#issuecomment-2750945783


More information about the build-dev mailing list