RFR: 8350801: Add a code signing hook to the JDK build system
Magnus Ihse Bursie
ihse at openjdk.org
Tue Mar 25 11:39:11 UTC 2025
On Tue, 25 Mar 2025 11:26:09 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:
> I removed the check because I noticed that UTIL_FIXUP_EXECUTABLE already performs such a check and so it was redundant.
I see.
The benefit of your solution was that the error message is tied to the configure argument and is more clear to the user. The check in UTIL_FIXUP_EXECUTABLE is more of a fallback insurance, and if it is triggered, the error message written might not be clear to the user what went wrong. So I still think it serves a purpose, to verify incoming arguments up-front, and it fit very nicely into the UTIL_ARG_WITH framework.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23807#issuecomment-2750968681
More information about the build-dev
mailing list