RFR: 8365932: Implementation of JEP 516: Ahead-of-Time Object Caching with Any GC [v3]
Erik Österlund
eosterlund at openjdk.org
Fri Oct 17 15:03:26 UTC 2025
On Fri, 17 Oct 2025 09:25:42 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Erik Österlund has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Dont print error message when there are no archived objects
>> - Fix issue in new test
>> - Change is_aot_thread implementation
>> - update AotJdk problem lists
>
> src/hotspot/share/prims/jvmtiExport.cpp line 1476:
>
>> 1474: // virtual threads. When exiting it is filtered out due to being hidden.
>> 1475: return;
>> 1476: }
>
> This has to be okay for now.
> It can be done in more generic way. For instance, there is a check for `thread->is_hidden_from_external_view()` below which would be nice to have earlier. However, now there is an inconsistency with the flag `is_hidden_from_external_view()` usage we need to address in the near future. So, I'm suggesting to keep this tweak as it is now.
> Most likely, we need to make sure other JVMTI events are not posted for this thread as well. I can file a separate JVMTI bug on it if it is okay with you.
Thanks for the review Serguei! I agree with your assessment. :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27732#discussion_r2440313109
More information about the build-dev
mailing list