RFR: 8365932: Implementation of JEP 516: Ahead-of-Time Object Caching with Any GC [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Oct 17 18:52:07 UTC 2025
On Fri, 17 Oct 2025 15:00:02 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiExport.cpp line 1476:
>>
>>> 1474: // virtual threads. When exiting it is filtered out due to being hidden.
>>> 1475: return;
>>> 1476: }
>>
>> This has to be okay for now.
>> It can be done in more generic way. For instance, there is a check for `thread->is_hidden_from_external_view()` below which would be nice to have earlier. However, now there is an inconsistency with the flag `is_hidden_from_external_view()` usage we need to address in the near future. So, I'm suggesting to keep this tweak as it is now.
>> Most likely, we need to make sure other JVMTI events are not posted for this thread as well. I can file a separate JVMTI bug on it if it is okay with you.
>
> Thanks for the review Serguei! I agree with your assessment. :)
Good. I've filed a JVMTI bug:
[8370128](https://bugs.openjdk.org/browse/JDK-8370128) AOT thread should not post JVMTI events
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27732#discussion_r2440915774
More information about the build-dev
mailing list