RFR: 8367034: [REDO] Protect ExecuteWithLog from running with redirection without a subshell
Magnus Ihse Bursie
ihse at openjdk.org
Mon Sep 8 11:39:49 UTC 2025
This is a redo of [JDK-8233115](https://bugs.openjdk.org/browse/JDK-8233115). The problem was that some of the AOT test command lines had `,` in them. Since this is interpreted as argument separator by make, it is not allowed, and it should be escaped to `$(COMMA)`.
However, it seems like the GNU make parser did not consider `,` to be an argument parser if it was nested inside matching `(` ... `)`, and so by pure luck it worked anyway, until I removed those subshell parentheses.
-------------
Commit messages:
- 8367034: [REDO] Protect ExecuteWithLog from running with redirection without a subshell
Changes: https://git.openjdk.org/jdk/pull/27140/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27140&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8367034
Stats: 44 lines in 5 files changed: 14 ins; 5 del; 25 mod
Patch: https://git.openjdk.org/jdk/pull/27140.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27140/head:pull/27140
PR: https://git.openjdk.org/jdk/pull/27140
More information about the build-dev
mailing list