RFR: 8367034: [REDO] Protect ExecuteWithLog from running with redirection without a subshell
Erik Joelsson
erikj at openjdk.org
Mon Sep 8 13:24:10 UTC 2025
On Mon, 8 Sep 2025 09:44:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> This is a redo of [JDK-8233115](https://bugs.openjdk.org/browse/JDK-8233115). The problem was that some of the AOT test command lines had `,` in them. Since this is interpreted as argument separator by make, it is not allowed, and it should be escaped to `$(COMMA)`.
>
> However, it seems like the GNU make parser did not consider `,` to be an argument parser if it was nested inside matching `(` ... `)`, and so by pure luck it worked anyway, until I removed those subshell parentheses.
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/27140#pullrequestreview-3196520667
More information about the build-dev
mailing list