Integrated: 8367034: [REDO] Protect ExecuteWithLog from running with redirection without a subshell
Magnus Ihse Bursie
ihse at openjdk.org
Mon Sep 8 16:49:25 UTC 2025
On Mon, 8 Sep 2025 09:44:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> This is a redo of [JDK-8233115](https://bugs.openjdk.org/browse/JDK-8233115). The problem was that some of the AOT test command lines had `,` in them. Since this is interpreted as argument separator by make, it is not allowed, and it should be escaped to `$(COMMA)`.
>
> However, it seems like the GNU make parser did not consider `,` to be an argument parser if it was nested inside matching `(` ... `)`, and so by pure luck it worked anyway, until I removed those subshell parentheses.
This pull request has now been integrated.
Changeset: 323b0201
Author: Magnus Ihse Bursie <ihse at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/323b02016e7458a0be39d52c9b0a5c61d579347e
Stats: 44 lines in 5 files changed: 14 ins; 5 del; 25 mod
8367034: [REDO] Protect ExecuteWithLog from running with redirection without a subshell
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/jdk/pull/27140
More information about the build-dev
mailing list