RFR: 8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information [v2]
Jaikiran Pai
jpai at openjdk.org
Mon Jan 12 15:49:00 UTC 2026
> Can I please get a review of this jtreg failure handler code change which addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8374181?
>
> The implementation in this failure handler generates a cores.html for each core file that was generated during the test run. The bug here is that instead of creating multiple "sections", one each for the core file, within an `<html>` element, it ends up creating multiple `<html>` elements one after another within the same HTML file. This causes the HTML rendering to go wrong.
>
> The commit in this PR addresses that issue by creating one section, under the `<html>` element, for each core file.
>
> I've verified that with this change, the cores.html is now correctly structured and rendered.
Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- merge latest from master branch
- 8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29150/files
- new: https://git.openjdk.org/jdk/pull/29150/files/87ebe973..7fc8f6e8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29150&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29150&range=00-01
Stats: 967 lines in 32 files changed: 837 ins; 49 del; 81 mod
Patch: https://git.openjdk.org/jdk/pull/29150.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29150/head:pull/29150
PR: https://git.openjdk.org/jdk/pull/29150
More information about the build-dev
mailing list