RFR: 8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information [v2]

Jaikiran Pai jpai at openjdk.org
Tue Jan 13 01:32:30 UTC 2026


On Mon, 12 Jan 2026 15:49:00 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this jtreg failure handler code change which addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8374181?
>> 
>> The implementation in this failure handler generates a cores.html for each core file that was generated during the test run. The bug here is that instead of creating multiple "sections", one each for the core file, within an `<html>` element, it ends up creating multiple `<html>` elements one after another within the same HTML file. This causes the HTML rendering to go wrong.
>> 
>> The commit in this PR addresses that issue by creating one section, under the `<html>` element, for each core file.
>> 
>> I've verified that with this change, the cores.html is now correctly structured and rendered.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - merge latest from master branch
>  - 8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information

Thank you Erik for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29150#issuecomment-3741351790


More information about the build-dev mailing list