Disabled jcheck in all build-infra repos

[Robert Ottenhag]

Kelly,

My vocabulary is somewhat misleading regarding "server side" here. I 
meant that I committed the change to the repositories locally on my 
machine as usual and then pushed it to the openjdk server using fpush, 
e.g. http://hg.openjdk.java.net/build-infra/jdk7/rev/f0fb16984aeb. I do 
not have any direct access to the openjdk server whatsoever ;-) Whatever 
the server side does with jcheck on commits is surely handled by John C. 
only.

/Robert


On 11/10/2011 03:07 PM, Kelly O'Hair wrote:
> Thanks for doing this. The server side was supposed to disable jcheck for these repos.
>
> Did you check with John Coomes?  Or have you been given a set of golden keys to the Mercurial server area? ;^)
>
> -kto
>
> On Nov 10, 2011, at 7:31 AM, Robert Ottenhag wrote:
>
>> Hi,
>>
>> I have now explicitly disabled jcheck for all build-infra repos since some of the recent changes in build-infra/jdk7 made jcheck fail when trying to pull and update. The disabling was done on the server by removing the directory ".jcheck" in the root of each repository, as specified in the jcheck.py header documentation.
>>
>> Alternative solutions such as disabling it locally in each $repo/.hg/hgrc file (overriding jcheck=...) or the global ~/.hgrc file where considered but rejected. The former needs to applied for each cloned build-infra repo, and the latter will also disable jcheck for any other standard Open or Closed JDK repo that actually requires it.
>>
>> Also note that jcheck was never intended to be run on the build-infra repos in the first place, allowing free form commits and rapid development without bug IDs, as the changes are never intended to be directly committed upstream, but selectively ported.
>>
>> The fix was separately reapplied to all build-infra repos (no, it was not merged...), including build-infra/{jdk7, jdk7-extra, jdk7-modules, jdk8}.
>>
>> Thanks
>>
>> /Robert
>>
>> -- 
>> Oracle
>> Robert Ottenhag | Senior Member of Technical Staff
>> Phone: +46850630961 | Fax: +46850630911 | Mobile: +46707106161
>> Oracle Java HotSpot Virtual Machine
>> ORACLE Sweden | Folkungagatan 122 | SE-116 30 Stockholm
>>
>> Oracle Svenska AB, Kronborgsgränd 17, S-164 28 KISTA, reg.no. 556254-6746
>>
>> Green Oracle
>>
>> Oracle is committed to developing practices and products that help protect the environment
>> --
>>
>>


-- 
Oracle
Robert Ottenhag | Senior Member of Technical Staff
Phone: +46850630961 | Fax: +46850630911 | Mobile: +46707106161
Oracle Java HotSpot Virtual Machine
ORACLE Sweden | Folkungagatan 122 | SE-116 30 Stockholm

Oracle Svenska AB, Kronborgsgränd 17, S-164 28 KISTA, reg.no. 556254-6746

Green Oracle

Oracle is committed to developing practices and products that help protect the environment
--