java-rmi.exe/cgi

[Robert Ottenhag]

Erik,

Ok, I'm good with that.

/R

> -----Original Message-----
> From: Erik Joelsson 
> Sent: Thursday, November 10, 2011 5:24 PM
> To: Robert Ottenhag
> Cc: Kelly O'Hair; build-infra-dev at openjdk.java.net
> Subject: Re: java-rmi.exe/cgi
> 
> You have a good point there, Robert. Since I already did the 
> conversion, 
> I'm now just tweaking it so that the converted makefile does the same 
> weird thing as the original.
> 
> /Erik
> 
> On 2011-11-10 17:21, Robert Ottenhag wrote:
> > This bug is mine actually. I submitted it to Sun back when 
> analyzing 
> > the JDK 6 build system for the JRockit JDK 6 port.
> >
> > My personal recommendation is that the removal should be 
> done in Open 
> > JDK 8 (and 7uX), and that the build-infra project should 
> not remove it 
> > on it's own, especially since the build-infra project does 
> not do bug 
> > tracking.
> >
> > I will take ownership of that bug and get it fixed.
> >
> > /Robert
> >
> >
> > On 11/10/2011 05:09 PM, Erik Joelsson wrote:
> >> What I don't understand is, when java-rmi.cgi was removed 
> java 1.2, 
> >> why leave the source and build file for it? They just stopped 
> >> bundling it in the images?
> >>
> >> /Erik
> >>
> >> On 2011-11-10 16:46, Kelly O'Hair wrote:
> >>> Actually,, I suspect we may have many of these CCC type 
> issues, we 
> >>> could just gather them up and
> >>> do one CCC, when we get closer to integrating the changes.
> >>> So I still vote for delete, but we need to track these things.
> >>>
> >>> -kto
> >>>
> >>> On Nov 10, 2011, at 10:40 AM, Kelly O'Hair wrote:
> >>>
> >>>> You have my vote too.
> >>>>
> >>>> However, if we are removing something, we will eventually need a 
> >>>> bug report and file a CCC for it (http://ccc.us.oracle.com)
> >>>> CCC is used whenever we do anything to the product that 
> a customer 
> >>>> might be surprised by, like deleting files or
> >>>> removing apis etc.
> >>>>
> >>>> Of course CCC might go away when the Sun LDAP goes away, not 
> >>>> sure...  We could wait to see what happens to CCC. ;^)
> >>>>
> >>>> -kto
> >>>>
> >>>> On Nov 10, 2011, at 10:27 AM, Erik Joelsson wrote:
> >>>>
> >>>>> Ah, thanks! The bug evaluation says that this shouldn't 
> be built 
> >>>>> at all. For the sake of faster builds, not building unnecessary 
> >>>>> stuff is the best way of improving speed. I vote for delete.
> >>>>>
> >>>>> /Erik
> >>>>>
> >>>>> On 2011-11-10 16:21, Kelly O'Hair wrote:
> >>>>>> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6512052
> >>>>>>
> >>>>>> My gut feeling is that we fix it, and then add this file to an 
> >>>>>> exclusion list when we get to the point of
> >>>>>> comparing built jdk images.
> >>>>>> But I'm willing to accept other suggestions.
> >>>>>>
> >>>>>> -kto
> >>>>>>
> >>>>>> On Nov 10, 2011, at 10:14 AM, Erik Joelsson wrote:
> >>>>>>
> >>>>>>> Sometimes when converting makefiles in the jdk repo, 
> I stumble 
> >>>>>>> over things that don't look right. The code seem to 
> suggest one 
> >>>>>>> intention, but careful inspection reveals a different 
> behavior. 
> >>>>>>> Normally I try to copy the actual behavior and put a 
> note in the 
> >>>>>>> new make file about it. Now I discovered something 
> that's just 
> >>>>>>> too weird:
> >>>>>>>
> >>>>>>> In "jdk/make/sun/rmi/cgi/Makefile" the program 
> "java-rmi.exe" is 
> >>>>>>> built. This looks like it's intended to be a windows native 
> >>>>>>> version of the "java-rmi.cgi" script that is 
> available on linux 
> >>>>>>> and solaris. The makefile even copies java-rmi.exe to 
> >>>>>>> java-rmi.cgi. When creating the j2sdk/jre images, 
> however, only 
> >>>>>>> the exe version is included. I verified this in the promoted 
> >>>>>>> builds of jdk 7 (b148 and a few others). The makefile 
> also tries 
> >>>>>>> to declare that the program be compiled from 
> >>>>>>> "jdk/src/windows/bin/java-rmi.c" (by declaring 
> FILES_c variable) 
> >>>>>>> but Program.gmk ignores this and just builds main.c (the 
> >>>>>>> standard java launcher) instead. So the "java-rmi.exe" in a 
> >>>>>>> windows distribution is just java.exe with a weird name.
> >>>>>>>
> >>>>>>> What is this script/program used for, is it used at 
> all, and how 
> >>>>>>> should I convert the building of it? I have tried compiling 
> >>>>>>> java-rmi.c and it seems to be working at least. (Gives same 
> >>>>>>> default output as the script on linux)
> >>>>>>>
> >>>>>>> /Erik
> >
> >
> 
>