hg: build-infra/jdk7/jdk: Removed a few unneeded make files.

Kelly O'Hair kelly.ohair at oracle.com
Mon Oct 17 08:50:13 PDT 2011


On Oct 16, 2011, at 7:46 PM, David Holmes wrote:

> On 16/10/2011 3:22 AM, Kelly O'Hair wrote:
>> For native libraries in the jdk repo, see:
>>    http://hg.openjdk.java.net/build-infra/jdk7/jdk/file/tip/make/CompileNativeLibraries.gmk
>> 
>> All the makefiles followed a pattern before, it's just that these patterns are being pulled together
>> into a single makefile invocation.
> 
> So we're turning on the centralized-decentralized cycle. The build currently recurses in sub-directories for each component and has individual Makefiles that utilize common settings and so there are some repeated patterns. The new build pulls all this up into a single top-level makefile that has entries for all the different components.

Basically, yes.

> 
> BTW the LIBZIP_CAN_USE_MMAP control variable has been lost in this process.

Before we are done, I expect that all these problems will be found. We are working on a install tree comparison tool that will verify
that old builds and new builds create the exact same binaries.

-kto

> 
> David
> ----
> 
>> -kto
>> 
>> On Oct 14, 2011, at 3:24 PM, David Holmes wrote:
>> 
>>> Okay I've been watching these push notification and a see a number of "removed unneeded makefiles" and I'm concerned. Where exactly has the logic from these makefiles (not these demo ones specifically) gone? Is it buried in the behemoth that is the configure file (12K+ lines!).
>>> 
>>> David
>>> 
>>> On 14/10/2011 10:51 PM, erik.joelsson at oracle.com wrote:
>>>> Changeset: eb852b6a4efd
>>>> Author:    erikj
>>>> Date:      2011-10-14 14:50 +0200
>>>> URL:       http://hg.openjdk.java.net/build-infra/jdk7/jdk/rev/eb852b6a4efd
>>>> 
>>>> Removed a few unneeded make files.
>>>> 
>>>> ! make/com/sun/Makefile
>>>> - make/com/sun/demo/Makefile
>>>> - make/com/sun/demo/jvmti/Makefile
>>>> - make/com/sun/demo/jvmti/hprof/Makefile
>>>> 
>> 




More information about the build-infra-dev mailing list