hg: build-infra/jdk8: 8005597: build-infra: bridgeBuild broken for pure openjdk build

[Erik Joelsson]

On 2012-12-29 12:56, David Holmes wrote:
> Hi Kelly,
>
> On 29/12/2012 2:32 PM, kelly.ohair at oracle.com wrote:
>> Changeset: 8b6a653041a6
>> Author:    ohair
>> Date:      2012-12-28 20:32 -0800
>> URL: http://hg.openjdk.java.net/build-infra/jdk8/rev/8b6a653041a6
>>
>> 8005597: build-infra: bridgeBuild broken for pure openjdk build
>>
>> ! common/makefiles/Jprt.gmk
>
> So this is being used to determine what parameters to give configure, 
> hence it can't use OPENJDK because that is an output of the configure 
> process?
>
> This seems to preclude me from submitting an OPENJDK build from a 
> forest that includes any of the main closed repos. At least if you 
> only looked for jdk/make/closed that would make it simple to do a 
> rename before a submission. The use of the other closed repos at build 
> time should be predicated both on their existence and whether OPENJDK 
> is set. (And test/closed is irrelevant to the build logic).
>
> And what if I set OPENJKDK=true in the environment - shouldn't that 
> override this closed repo test ?
>
> David
> -----
I'm also thinking this logic is flawed. There is no need to tell 
configure that it's open only if there are no closed repos available, it 
will figure it out on its own. Only reason to force it would be if there 
are closed repos available, but the user wants to run open only, by 
setting OPENJDK=true.

If you have a case that didn't work, please let us know.

/Erik