hg: build-infra/jdk8: 8005597: build-infra: bridgeBuild broken for pure openjdk build

[Kelly O'Hair]

On Dec 29, 2012, at 3:56 AM, David Holmes wrote:

> Hi Kelly,
> 
> On 29/12/2012 2:32 PM, kelly.ohair at oracle.com wrote:
>> Changeset: 8b6a653041a6
>> Author:    ohair
>> Date:      2012-12-28 20:32 -0800
>> URL:       http://hg.openjdk.java.net/build-infra/jdk8/rev/8b6a653041a6
>> 
>> 8005597: build-infra: bridgeBuild broken for pure openjdk build
>> 
>> ! common/makefiles/Jprt.gmk
> 
> So this is being used to determine what parameters to give configure, hence it can't use OPENJDK because that is an output of the configure process?

Correct. This is for the bridgeBuild and is primarily a JPRT thing, and hopefully a temporary thing.
The "ifdef OPENJDK" that was already there.

> 
> This seems to preclude me from submitting an OPENJDK build from a forest that includes any of the main closed repos. At least if you only looked for jdk/make/closed that would make it simple to do a rename before a submission. The use of the other closed repos at build time should be predicated both on their existence and whether OPENJDK is set. (And test/closed is irrelevant to the build logic).

I am sick and tired of developers sending in arbitrary sets of repos into JPRT then complaining to me that
things don't work. JPRT does tests too, and if you are building a closed repo, you need the closed tests.
If you are building openjdk you need to exclude the closed sources. I have to tighten this down or go crazy.

I'm only speaking to JPRT and this bridgeBuild feature here, developer builds are a separate issue.

> 
> And what if I set OPENJKDK=true in the environment - shouldn't that override this closed repo test ?

I really don't want to deal with openjdk builds that don't work because of some interference caused by
the existence of closed files. I think there is a big risk here.
There are ways to exclude these closed sources or repos when doing JPRT submits of openjdk builds,
those mechanisms need to be used as far as I am concerned.
It's silly and risky to send in all the closed sources to JPRT and tell it to build an openjdk.

-kto

> 
> David
> -----