LIBARCH replacement?

[David Holmes]

On 5/10/2012 7:28 PM, Magnus Ihse Bursie wrote:
> On 2012-10-05 06:09, David Holmes wrote:
>> But which of the above should be used to replace LIBARCH? The
>> candidates (based on the fact they have the right value) are:
>>
>> OPENJDK_TARGET_CPU_LIBDIR:=/i386
>> OPENJDK_TARGET_CPU_LEGACY_LIB:=i386
>> OPENJDK_TARGET_CPU_OSARCH:=i386
>>
>> I suspect the first one was the intended replacement - right?
>
> Check in hotspot-spec.gmk.in what it says at the line LIBARCH=@... at .
> (Sorry I'm at home and do not have access to the source today.)

And the winner is ...

LIBARCH=$(OPENJDK_TARGET_CPU_LEGACY_LIB)

So might I suggest that this gets renamed to 
OPENJDK_TARGET_CPU_LEGACY_LIBARCH? Or even (as it is a legacy setting) 
just OPENJDK_LEGACY_LIBARCH?

For the record in the profile builds the files that define the profile 
contents have to express the arch-specific file locations using a 
variable name that the make system will cause to be replaced correctly.

Thanks,
David

>> But the leading slash is problematic for my usage (hence I've used the
>> second one). I don't think slashes belong in simple variables.
>
> The reason for the slash is that on some platforms (read: macosx, and
> possibly Windows (don't remember)) this value is empty, since there is
> no specific sub-directory the files should be put in. This is similar to
> the ..._ISADIR variable. I tried to name stuff "-DIR" when they included
> a slash to at least get some consistency in this mess.
>
> /Magnus