LIBARCH replacement?

[Magnus Ihse Bursie]

On 2012-10-08 03:42, David Holmes wrote:
> On 5/10/2012 7:28 PM, Magnus Ihse Bursie wrote:
>> Check in hotspot-spec.gmk.in what it says at the line LIBARCH=@... at .
>> (Sorry I'm at home and do not have access to the source today.)
>
> And the winner is ...
>
> LIBARCH=$(OPENJDK_TARGET_CPU_LEGACY_LIB)
>
> So might I suggest that this gets renamed to 
> OPENJDK_TARGET_CPU_LEGACY_LIBARCH? Or even (as it is a legacy setting) 
> just OPENJDK_LEGACY_LIBARCH?

Sure, rename it if you think it's helpful. (You'll have to do it 
yourself, though, I won't have the time to fix it now).

I recommend keeping the OPENJDK_TARGET_CPU_ prefix though -- I went 
through all the legacy platform definitions and tried to get them 
connected to the "new and proper" variable by the prefix. The idea was 
that if you know the new system you understand that it's a variation on 
a certain variable, and it helped to remove all instances were we used 
the old-style variables when the new would do just as well (in all 
Makefile if statements, e.g.)

But as you say, this doesn't really help if you go the other way, i.e. 
want to figure out what to use for the variable that used to be LIBARCH. 
Maybe we should have a translation table for that somewhere?

/Magnus