Need official reviewers: hotspot makefile changes from build-infra

[David Holmes]

Hi Kelly,

On 17/10/2012 3:57 AM, Kelly O'Hair wrote:
>
> These will be integrated into the hotspot-rt forest at http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/
>
> 8000990: Improve logging in hotspot repo builds for new build-infra
>
> http://cr.openjdk.java.net/~ohair/jdk8/hotspot.build.infra.logging/webrev/
>
> I did not make these changes, so I'd like to create this changeset with an appropriate owner and list of
> reviewers (which I will be one).

Whomever made the changes can either be the changeset Author (if 
qualified) or else the contributor with you as the Author.

> If there are issues to resolve with these changes, it would be best if that appropriate owner made the changes
> in the build-infra forest and I will re-generate the patch.

I got a real sense of deja-vu looking at this. I don't understand what 
happened to the TEST_IN_BUILD changes - somehow half of that work got 
left behind ??

As for the $(LOG_INFO) changes, I don't get it. This kind of change 
almost makes sense:

-      _JUNK_ := $(shell echo >&2 "INFO: ALT_OBJCOPY=$(ALT_OBJCOPY)")
+      _JUNK_ := $(if $(LOG_INFO),,$(shell echo >&2 "INFO: 
ALT_OBJCOPY=$(ALT_OBJCOPY)"))

I think the intent is that if $(LOG_INFO) is not empty then we will echo 
the information. But the way it is written we do the echo if LOG_INFO is 
empty - which I don't understand. But I don't understand all the changes 
of the form:

@echo $(LOG_INFO) ...

What is that supposed to do? What value will LOG_INFO have?

That aside in top.make where you add:

+	@echo Making vm...

shouldn't that be

+	@echo $(LOG_INFO) Making vm...

?

As for the windows cygpath changes - I can't comment on that. That seems 
not to be build-infra specific.

David
-----

> -kto