Need official reviewers: hotspot makefile changes from build-infra

[Magnus Ihse Bursie]

On 2012-10-18 07:26, David Holmes wrote:
>> Yep. By mistake, what was pushed into mainline was the first attempt at
>> the test-in-build fix, not the latest one. :-( I've been mailing
>> privately to Kelly on the best way to resolve this, but he's been away
>> for a while and haven't had time to sort it out. I'm not sure what's
>> happening now, if pushing this patch would result in the correct code or
>> not. Even though it will need more work, I think it would be a good
>> thing to separate that out from this current patch.
>
>
> Ok. So I'm assuming that without the rest of this we can't actually 
> set TEST_IN_BUILD=false and disable test_gamma ?
I'm not quite sure what actually is in there, since it's like half of 
everything. But presumably no. I'll try and spend some time to figure 
out how to correct the test-in-build-patch.
> Ok. The mechanism is surprising but it's not completely unclear what 
> this will do: echo when logging at info level is enabled. Though 
> "$(LOG_INFO) @echo ..." would look more intuitive. Or change @echo to 
> @$(ECHO) and hide this all behind the definition of ECHO (which is 
> what happens in other parts of the build - right?)

That would effectively put all $(ECHO) on the same log level... But you 
could of couse introduce a ECHO_LOG_INFO or something like that. I'm not 
sure it's clearer.

> Okay - so how many log levels do we have? Seems to be only two. (Not 
> that I really care as I will always build with all logging enabled - 
> and expect JPRT to do the same.)

We have:
warn (default) - only print high-level progress information and warnings
info - also print additional information, like which file we're 
currently compiling
debug - also print command lines executed (closest to the old default)
trace - also print makefile target reasons for execution and all 
non-recipe make $(shell) commands.

The log levels are inspired ("stolen") from log4j.

/Magnus