Abort review! Re: Need official reviewers: hotspot makefile changes from build-infra
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Fri Oct 19 04:22:28 PDT 2012
On 2012-10-18 07:26, David Holmes wrote:
>
> Right. These FDS related statements are really extended debugging
> information to help everyone figure out why they do, or do not, get
> the debuginfo files, based on different flags and the existance of the
> objcopy tool. I find them somewhat noisy as they get reported multiple
> times. Given you are effectively adding different levels of verbosity
> to the logging I think it would be fine to change these to something
> more "natural" (Of course we run it past Dan :) ). As it is the sense
> of the test and name seem reversed: I don't expect LOG_INFO being
> empty to enable the output.
These changes appearantly requires too much work to be worth the effort,
at least in the current situation when we must focus our work on getting
build-infra the final steps into being default.
I'll back out those changes from build-infra/hotspot. No further reviews
will be needed for the logging. If there are other fixes in hotspot that
*really* needs to be done, we'll send out separate reviews.
/Magnus
More information about the build-infra-dev
mailing list