Status of the langtools repo in the build-infra forest

[Jonathan Gibbons]

Some of the changes for smart-javac should be done independently, as a 
change to javac to go in via TL/langtools.  This will reduce the changes 
needed to javac for the benefit of smart-javac.  I started work on that 
patch yesterday, and should have it shortly.

-- Jon

On 10/25/2012 07:13 AM, Magnus Ihse Bursie wrote:
> Similar to hotspot, the langtools repo has also been messy. The reason 
> for this is basically that it contains two kinds of changes, Fredriks 
> smartjavac implementation, and changes to the new buildsystem. On top 
> of that, Fredrik has pulled some fixes from the tl forest, while 
> Kelly, Erik and I have pulled from the build forest.
>
> The smartjavac changes will have to be integrated via langtools, but 
> the buildsystem stuff should go via build.
>
> On top of that, there is a third change, which is a modification to 
> test/Makefile to adapt to running tests via build-infra. I have 
> published a separate webrev for that change. It is non-essential, 
> however, so if it turns out to be problematic, we can just drop it.
>
> Currently, the only build-infra changes are minimal, it's a few lines 
> of changes log level, a changed filename and new top-level wrapper 
> similar to those in the other repos. However, due to the filename 
> change, the actual change is hard to see. Here it is for your benefit. 
> This info should probably be attached when the formal request for a 
> code review turns up.
>
> --- /localhome/hg/build-jdk8-NEW/langtools/makefiles/Makefile
> +++ /localhome/hg/build-infra-jdk8/langtools/makefiles/BuildLangtools.gmk
> @@ -143,13 +143,13 @@
>                  $(LANGTOOLS_OUTPUTDIR)/gensrc/_the_props.d
>                 mkdir -p $(@D)
>          mkdir -p $(LANGTOOLS_OUTPUTDIR)/tmpstubs
> -               echo Generating stubs from JDK sources.
> +               echo $(LOG_INFO) Generating stubs from JDK sources.
>                 ($(TOOL_GENSTUBS_CMD) -s 
> $(LANGTOOLS_OUTPUTDIR)/tmpstubs -sourcepath $(JDKS) $(STUBCLASSES) && 
> echo STUBS_ARE_CREATED=yes > $@)
>          if $(DIFF) -x "_the*" -rq $(LANGTOOLS_OUTPUTDIR)/tmpstubs 
> $(LANGTOOLS_OUTPUTDIR)/genstubs > /dev/null 2>&1; then \
> -            echo No changes in the stubs!; \
> +            echo $(LOG_INFO) No changes in the stubs!; \
>              rm -rf $(LANGTOOLS_OUTPUTDIR)/tmpstubs; \
>          else \
> -            echo Changes in stubs detected!; \
> +            echo $(LOG_INFO) Changes in stubs detected!; \
>              rm -rf $(@D); \
>              mv $(LANGTOOLS_OUTPUTDIR)/tmpstubs $(@D); \
>          fi
>
> /Magnus