Changes to be pushed into jdk8/build

[Magnus Ihse Bursie]

On 2012-09-12 04:19, Kelly O'Hair wrote:
> This is the webrev I came up with for openjdk8:
>
> 7197849: Update new build-infra makefiles
>
> http://cr.openjdk.java.net/~ohair/openjdk8/build-infra3/webrev/
>
> The hotspot changes should probably go in a different way, perhaps jdk8/hotspot-rt/hotspot.
> The langtools changes I don't plan on integrating.

I have looked at this patch (most of it, anyway), and there seems to be 
some polishing needed. :-)

First of all, some structuring stuff:
* The langtools diffs look worse than they are since you've diffed 
against the latest mainline, but Erik did not integrate langtools (since 
it contained a change that broke our compare script). Fredrik didn't 
know about this (since Erik's mail got stuck) and integrated it anyway, 
but that was appearantly after your diff.
* Most of the actual changes in langtools are smartjavac, and I think 
you are correct in leaving them out.
* However, makefiles/Makefile contains real changes that should be 
included. And so does make/Makefile (a fix to make testing work with the 
new build system).

* In hotspot, there is this mix of old lingering changes that never was 
pushed, e.g. the fix to make running Queens optional, and some 
$(filter-out ARCH) that Fredrik did long time ago that I never figured 
out the meaning of. I think I should try to fix up the issues with the 
"disable Queens" patch and resubmit it for code review. However, this 
should not be included in this fix.
* On the other hand, there *are* valid changes in hotspot that should be 
included now. These are basically a bunch of $(sort $(OBJS)).

I also noted several pieces of code that should be fixed up before 
pushing to mainline, like we should remove code instead of comment it 
out, typos etc. I'll try to fix them instead of listing them here. :-)

/Magnus