Need reviewer for build-infra integration into jdk8/build

David Holmes david.holmes at oracle.com
Thu Sep 13 20:19:36 PDT 2012


Hotspot review ...

On 14/09/2012 12:38 PM, Kelly O'Hair wrote:
> 1. http://cr.openjdk.java.net/~ohair/openjdk8/repo-./webrev/
>
>    7197849: Update new build-infra makefiles
>
>    Lots and Lots of changes to the build-infra makefiles. Added top level Makefile, javadoc Makefile,
>    and a preliminary netbeans project definition.
>    Much work has gone into making the builds accurately compare to old makefile builds.

BTW 7130909 applies here too.

> 6. http://cr.openjdk.java.net/~ohair/openjdk8/repo-hotspot/webrev/
>
>    7198329: Add $(sort) to object files used in links makes binaries more consistent
>    7172012: Make test-in-build an option (Queens)

Also has a general fix to allow cross-compilation to work (linux only).

>    I'll try and integrate these hotspot changes through the hotspot-rt forest.

These changes look okay to me, though the proliferation of:

+ ifeq ($(TEST_IN_BUILD),true)
           cd $(OSNAME)_$(BUILDARCH)_compiler2/$@ && ./test_gamma
+ endif

is truly awful (both within files and across them). Seems to me we 
should be able to write a simple function to handle this - but not now. :)

I'm unclear how/if the order of the object files is affected by the map 
files? Does the map file just build a quick index into the library?

David
------



More information about the build-infra-dev mailing list